Repository navigation
fix(datum): keep the original bytes of decoded inline datums - #603
Merged
Merged
Conversation
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding a transaction dropped each inline datum's original bytes, and encoding rebuilt them with the default data layout. When the layout differed, for example a definite map
a10102that becamebf0102ff, re-encoding changed the body. Adding a witness withaddVKeyWitnessesBytesthen changed the transaction id, and the node rejected the transaction with 3100 (invalid signatures).Decoding now records the exact bytes inside tag 24 against the
InlineDatumit returns, and encoding writes them back when it is given that same object. A new or edited datum is a new object, so it still gets the default encoding. The record lives in a new sharedOriginalBytesmodule, a WeakMap from a decoded object to its bytes, which later steps of #581 will reuse for other parts of the transaction.Closes the inline-datum part of #576. Step 1 of #581.