Repository navigation
fix(cbor): match byte-string map keys when replaying a decoded map - #608
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A decoded transaction rewrote witness datums and redeemers that contain a Plutus data map with byte-string keys.
Transaction.fromCBORHexthentoCBORHex, andTransaction.addVKeyWitnessesHex, turnedd8799fa141019f0102ffffintod8799fa14101820102ff, so the node rejected the witnessed transaction with a script data hash mismatch (3113). When the encoder replays a decoded map, it looks up each captured key in the map. The captured key decodes as a plain byte array, while the same key in a data map is aBoundedBytesnode, so the lookup never matched. The encoder then treated the key as new and dropped the captured format of its value.The replay now compares keys with every
BoundedBytesnode unwrapped to its bytes, at any depth, so list and constructor keys that contain byte strings match too. Each captured key takes the first matching entry that no earlier key took, so a repeated byte key keeps its own value. Fresh encodings do not go through this path, so their bytes stay the same.Part of #576, see #576 (comment).