Fixing BCIT and in app tests in CI#1048
Draft
franco-zalamena-iterable wants to merge 8 commits intomasterfrom
Draft
Fixing BCIT and in app tests in CI#1048franco-zalamena-iterable wants to merge 8 commits intomasterfrom
franco-zalamena-iterable wants to merge 8 commits intomasterfrom
Conversation
actions/setup-java@v1.4.3 was resolving java-version: 17 through the deprecated AdoptOpenJDK API. Between Apr 21 and Apr 22 that resolution shifted from 17.0.18 to 17.0.19, and the artifact returned for 17.0.19 makes sdkmanager exit immediately, breaking the emulator-runner action's Install Android SDK step on every run since. Upgrade setup-java to v4.8.0 with distribution: temurin so the JDK is pinned to a deterministic Adoptium Temurin build, and replace the deprecated gradle/wrapper-validation-action with gradle/actions/wrapper-validation@v4. Applied to all three jobs (check, unit-tests, instrumentation-tests). Co-authored-by: Cursor <cursoragent@cursor.com>
scripts/trace-bcit.sh and the integration-tests printBuildConfig Gradle task were used for local replication while diagnosing SDK-170. They are not invoked by CI. Removing them keeps the PR diff focused on what actually fixes the in-app E2E job. Co-authored-by: Cursor <cursoragent@cursor.com>
The previous CI run on macos-15-intel (2 cores / 3GB AVD on HVF) starved system_server during cold boot. Logcat shows continuous ANRs in systemui, nexuslauncher, gms.persistent, googlequicksearchbox, com.android.phone, com.google.android.as, keychain, permissioncontroller — all before and during the test. UiAutomator's wait then timed out with current package = 'android' (a system dialog) sitting on top of MainActivity, so btnInAppMessages was unreachable. Switching to ubuntu-latest with KVM acceleration gives the AVD real hardware virtualization on a 4 vCPU / 16GB host, stopping the ANR storm and letting the test see MainActivity within its 30s wait. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test