Skip to content

[SDK-791] Run the background showMessage test without a timeout #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franco-zalamena-iterable wants to merge 1 commit into
base: fix/SDK-791-show-message-main-thread
Choose a base branch
from
+38 −27
Open

[SDK-791] Run the background showMessage test without a timeout #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions iterableapi/src/test/java/com/iterable/iterableapi/IterableInAppManagerThreadingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
import static junit.framework.Assert.assertTrue;
import static org.robolectric.Shadows.shadowOf;

import android.os.Handler;
import android.os.HandlerThread;

import androidx.activity.ComponentActivity;

import org.junit.After;
Expand All @@ -19,10 +16,6 @@
import org.robolectric.android.controller.ActivityController;
import org.robolectric.shadows.ShadowDialog;

import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicReference;

public class IterableInAppManagerThreadingTest extends BaseTest {

private ActivityController<ComponentActivity> controller;
Expand Down Expand Up @@ -51,27 +44,9 @@ public void tearDown() {

@Test
public void showMessage_fromBackgroundLooperThread_displaysOnMainThreadWithoutCrashing() throws InterruptedException {
// A looper thread, like the React Native native-modules thread.
HandlerThread background = new HandlerThread("background");
background.start();
final AtomicReference<Throwable> thrown = new AtomicReference<>();
final CountDownLatch done = new CountDownLatch(1);
new Handler(background.getLooper()).post(new Runnable() {
@Override
public void run() {
try {
inAppManager.showMessage(message, true, null);
} catch (Throwable t) {
thrown.set(t);
} finally {
done.countDown();
}
}
});
assertTrue(done.await(5, TimeUnit.SECONDS));
background.quitSafely();
LooperTestUtils.runOnBackgroundLooperAndWait(
() -> inAppManager.showMessage(message, true, null));

assertNull(thrown.get());
assertNull(IterableInAppDialogNotification.getInstance());
assertFalse(message.isRead());
assertFalse(message.isMarkedForDeletion());
Expand Down
36 changes: 36 additions & 0 deletions iterableapi/src/test/java/com/iterable/iterableapi/LooperTestUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package com.iterable.iterableapi

import android.os.Handler
import android.os.HandlerThread
import org.robolectric.Shadows.shadowOf
import java.util.concurrent.atomic.AtomicReference

object LooperTestUtils {

/**
* Runs [action] to completion on a background looper.
* Work that [action] posts to the main looper stays queued.
*/
@JvmStatic
@Throws(InterruptedException::class)
fun runOnBackgroundLooperAndWait(action: Runnable) {
val thread = HandlerThread("test-background")
val failure = AtomicReference<Throwable>()
thread.start()
try {
shadowOf(thread.looper).pause()
Handler(thread.looper).post {
try {
action.run()
} catch (error: Throwable) {
failure.set(error)
}
}
shadowOf(thread.looper).idle()
} finally {
thread.quit()
thread.join()
}
failure.get()?.let { throw AssertionError("Background action failed", it) }
}
}
Loading