Repository navigation
Conversation
…e English guide The two CLA links in the Chinese contribution guide point at hashed website asset names that no longer exist: both return HTTP 404. The website now serves the same documents from https://ivorysql.org/pdf/individual_cla.pdf and https://ivorysql.org/pdf/corporate_cla.pdf, which is also what the live contribution-guidelines page links to. The English contribution guide does not mention the CLA at all, even though an unsigned contributor's pull request cannot enter review. Add a "Signing the CLA" subsection under "Licensing of IvorySQL contributions" with both agreements and the cla@ivorysql.org address. Documentation only, CN + EN, 2 files. Closes #<ISSUE_NUMBER> Signed-off-by: 王诗焱 <3372848903@qq.com>
|
🚀 IvorySQL-Docs Preview Ready
|
Author
|
CLA: the Individual Contributor License Agreement for 王诗焱 (GitHub: qwer381) was signed and emailed to cla@ivorysql.org on 2026-11-10 (delivery confirmed by the mail provider). If the community needs it re-sent to another address, or needs a scanned wet signature instead of the typed one, say the word and I will send it again. |
qwer381
force-pushed
the
docs/fix-v5.6-cla-links
branch
2 times, most recently
from
November 13, 2026 05:54
76e1165 to
d87fe87
Compare
|
🚀 IvorySQL-Docs Preview Ready
|
|
🚀 IvorySQL-Docs Preview Ready
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs(8.1): repair the two dead CLA download links and add a CLA section to the English guide
Closes #376
What
CN/modules/ROOT/pages/8.1.adoc: replace the two hashed website asset URLs for the CLA PDFs with the stable paths the site serves today (https://ivorysql.org/pdf/individual_cla.pdfandhttps://ivorysql.org/pdf/corporate_cla.pdf). The old URLs return 404.EN/modules/ROOT/pages/8.adoc: add a==== Signing the CLAsubsection underLicensing of IvorySQL contributions. The English guide never mentioned the CLA, although it is a hard requirement for review.2 files changed, 11 insertions(+), 2 deletions(-).Why
Signing the CLA is mandatory:
8.1.adocitself says a pull request from a contributor without a signed CLA cannot enter the review process, andIvorySQL/IvorySQLREADME.md:97repeats it for code contributions. With the links dead, a new contributor following the Chinese guide cannot even download the document; and a contributor reading the English guide is never told that the step exists.The replacement URLs are the ones already used by the live page
https://ivorysql.org/community/contribution-guidelines— the page the main repository README points at for contribution guidelines — so this aligns the documentation with the website instead of inventing a new location.The two changed hunks
CN/modules/ROOT/pages/8.1.adoc, lines 103-104:EN/modules/ROOT/pages/8.adoc: nine lines inserted between==== Licensing of IvorySQL contributionsand=== What Contribution Can You Make:Testing
HTTP status of the four URLs involved (2026-11-10):
Local Antora 3.2.2 build (same generator as the repo's
pr-previewworkflow), before -> after:The commit is based on
v5.6@7c3f4a6and applies to it with no conflicts; the diffstat is the2 files changed, 11 insertions(+), 2 deletions(-)quoted above.Checklist