Repository navigation
fix: process webhook events instead of silently returning 200 status - #7891
Conversation
|
@atul-upadhyay-7 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamodx6
left a comment
There was a problem hiding this comment.
Hello! Thanks for your work on processing webhook events instead of just returning a 200 status. Ensuring that we properly handle the payloads is crucial for data consistency. I noticed that the main \Format · Lint · Typecheck · Test\ CI workflow is failing. I have triggered a rerun of the CI pipeline for this PR to see if it was a flaky failure, but if it fails again, please fix the tests/linting errors locally and update this PR!
Labels assigned:
- \level:intermediate: Dealing with webhook payload parsing and processing requires a good understanding of the data models.
- \ ype:bug: Addresses an issue where payloads were ignored.
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
Aamodx6
left a comment
There was a problem hiding this comment.
Fixing the webhook processing logic in route.ts to actually handle events instead of silently returning 200 is a critical fix. However, the CI checks are failing. Please resolve the issues and rerun the CI pipeline.
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
Aamodx6
left a comment
There was a problem hiding this comment.
Thanks for opening this PR! The changes described in your PR description sound exactly like what's needed to fix the webhook processing issue.
However, it looks like there are no code changes included in this pull request (0 additions, 0 deletions). It seems you might have forgotten to commit your changes or push them to this branch before opening the PR.
Please make sure you have committed your modifications to \�pp/api/webhook/route.ts\ and pushed them to this branch. Once the code is here, we can proceed with a full review!
Label Justification:
- \level:intermediate: Webhook parsing and event processing is an intermediate backend task.
- \quality:clean: Applied as default pending full review.
- \ ype:bug: Fixes silent failure in webhooks.
- \mentor:Aamod007: Assigned as required.
Aamodx6
left a comment
There was a problem hiding this comment.
This PR has 3 commits but 0 files changed and an empty diff — it appears the changes are already in the base branch or the branch is out of date. Could you please check if this PR is still needed and rebase if appropriate?
- Recreated /api/webhook route with proper event processing - Imports parseWebhookEvent, cacheEvent, evaluateAlerts from webhook-handler - Rate limiting, signature verification, and payload validation - Returns appropriate success/error responses - Added comprehensive test suite (10 tests) Fixes #7887
|
@Aamod007 Thanks for the review! I've addressed the empty diff issue by recreating the webhook route with proper event processing. What was wrong: Changes made:
Validation results:
Ready for re-review! 🙏 |
|
🎉 Congratulations @atul-upadhyay-7! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
This PR fixes the issue where the webhook endpoint receives events but fails to process them silently returning 200 status. The endpoint now properly processes webhook events by parsing, caching, and evaluating alerts.
Changes Made
Testing
Impact
Issue Reference
Fixes #7887
Labels