Skip to content

fix(webhook): remove legacy webhook endpoint#7892

Open
tri-pti wants to merge 1 commit into
JhaSourav07:mainfrom
tri-pti:remove-legacy-webhook
Open

fix(webhook): remove legacy webhook endpoint#7892
tri-pti wants to merge 1 commit into
JhaSourav07:mainfrom
tri-pti:remove-legacy-webhook

Conversation

@tri-pti

@tri-pti tri-pti commented Jul 9, 2026

Copy link
Copy Markdown

Description

Closes #7876

This PR removes the legacy /api/webhook endpoint and its associated test since /api/webhooks/github is the only supported GitHub webhook endpoint.

It also updates the self-hosting documentation to clearly document the correct webhook configuration.

Changes

  • Removed app/api/webhook/route.ts
  • Removed app/api/webhook/route.test.ts
  • Added a new section in docs/self_hosting.md documenting:
    • GITHUB_WEBHOOK_SECRET
    • the correct webhook endpoint (/api/webhooks/github)
    • the required GitHub webhook configuration
    • that this is the only supported webhook endpoint

Pillar

  • 🛠️ Other (Bug fix, refactoring, docs)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm run format and npm run lint locally and resolved all errors.
  • My commits follow the Conventional Commits format.
  • README.md update not required.
  • I have starred the repo.
  • I have made sure that I have only one commit in this PR.
  • The change does not affect SVG rendering.
  • (Recommended) I joined the CommitPulse Discord community.

@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@tri-pti is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

Asset PR Size Base Size Difference Status
static/chunks/app/api/webhook/route-[hash].js - 0.24 KB -0.24 KB (-100.00%) 🗑️ Deleted

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3916.86 KB 3917.41 KB -0.54 KB (-0.01%)
Total CSS 325.86 KB 325.86 KB 0 B

@Aamod007 Aamod007 added mentor:Aamod007 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:refactor Code changes that neither fix a bug nor add a feature labels Jul 10, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for removing the legacy webhook endpoint. It's always great to clean up dead code and reduce our attack surface. Removing unused routes keeps the API surface lean. CI checks are looking green!

Labels assigned:

  • \level:beginner: Removing a legacy endpoint is straightforward.
  • \quality:clean: Good cleanup task.
  • \ ype:refactor: Code cleanup/removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:refactor Code changes that neither fix a bug nor add a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: POST /api/webhook validates and accepts GitHub webhooks but never processes them (dead endpoint, silent 200)

2 participants