Skip to content

Refactor Logger to Export SENSITIVE_KEYS for Enhanced Type Safety - #8342

Closed
tmdeveloper007 wants to merge 1 commit into
JhaSourav07:mainfrom
tmdeveloper007:#8332
Closed

Refactor Logger to Export SENSITIVE_KEYS for Enhanced Type Safety#8342
tmdeveloper007 wants to merge 1 commit into
JhaSourav07:mainfrom
tmdeveloper007:#8332

Conversation

@tmdeveloper007

Copy link
Copy Markdown

Summary of What Has Been Done

Exported the SENSITIVE_KEYS constant array from lib/logger.ts as a named export const with as const assertion for improved type safety. Added comprehensive JSDoc documentation including usage examples.

Changes Made

  • lib/logger.ts: Changed const SENSITIVE_KEYS to export const SENSITIVE_KEYS as const with JSDoc including @example showing how to use it for sensitive field detection.

Impact it Made

Allows other modules to reuse the same sensitive key detection logic without duplicating the array, improving maintainability and consistency. The as const assertion makes the array readonly and literal, which TypeScript can use for more precise type checking.

Closes #8332

Note: Please assign this PR to the tmdeveloper007 account.

@vercel

vercel Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

@tmdeveloper007 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@retenta-bot

retenta-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown

This pull request enhances the maintainability and type safety of our codebase by exporting the SENSITIVE_KEYS constant for reuse. This aligns with our previous decisions to improve type safety, such as adding TypeScript compiler verification for components and introducing type guard functions. Thank you for your contribution, and feel free to reach out if you have any questions!

@retenta-bot retenta-bot Bot changed the title refactor(logger): exported SENSITIVE_KEYS for reuse Refactor Logger to Export SENSITIVE_KEYS for Enhanced Type Safety Jul 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @tmdeveloper007! Thanks for your interest in contributing to CommitPulse! 🙏

Unfortunately, this PR has been automatically closed because you are not assigned to the linked issue #8332 — refactor(logger): export SENSITIVE_KEYS for reuse.

To avoid this in the future, please follow these steps:

  1. Claim the issue — Comment /claim on #8332 if you are the issue author, or ask a maintainer to /assign you.
  2. Wait for confirmation — The bot will confirm your assignment with a ✅ reply.
  3. Then open your PR — Link the issue with Fixes #8332 in your description.

💡 You can be assigned to up to 5 open issues at a time. Check your current assignments before claiming a new one.

We look forward to your contribution once you're assigned! 🚀

@github-actions github-actions Bot closed this Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(logger): export SENSITIVE_KEYS for reuse

1 participant