Skip to content

Refactor Calculate Module: Document DaysInYear Export for Reuse#8353

Open
tmdeveloper007 wants to merge 1 commit into
JhaSourav07:mainfrom
tmdeveloper007:#8337
Open

Refactor Calculate Module: Document DaysInYear Export for Reuse#8353
tmdeveloper007 wants to merge 1 commit into
JhaSourav07:mainfrom
tmdeveloper007:#8337

Conversation

@tmdeveloper007

Copy link
Copy Markdown

Summary of What Has Been Done

This PR addresses issue #8337.

See the corresponding issue for full details.

Closes #8337

Note: Please assign this PR to the tmdeveloper007 account.

@retenta-bot

retenta-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown

This pull request improves the documentation of the daysInYear export, which will aid in its reuse across the codebase. It's important to ensure that such changes are well-documented to maintain code quality and usability. This aligns with our previous decision to fix dead code in the calculate functions, emphasizing the importance of clarity and functionality in our calculations. Thank you for your contribution, and I look forward to your updates!

@retenta-bot retenta-bot Bot changed the title refactor(calculate): documented daysInYear export for reuse Refactor Calculate Module: Document DaysInYear Export for Reuse Jul 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 4052.50 KB 4052.50 KB 0 B
Total CSS 338.94 KB 338.94 KB 0 B

@Aamod007 Aamod007 added level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. mentor:Aamod007 type:docs Documentation changes, wikis, or README updates type:refactor Code changes that neither fix a bug nor add a feature labels Jul 27, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding export + JSDoc to daysInYear for reuse. Clean change. CI is failing — please fix.

Labels: level:beginner, quality:clean, type:docs, type:refactor, mentor:Aamod007

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewing after noting the only CI failure is Vercel authorization (not code-related). All other checks (Format · Lint · Typecheck · Test, Production Build, CodeQL) pass. Approving — the Vercel deploy auth is a repo-level config issue, not a code problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:docs Documentation changes, wikis, or README updates type:refactor Code changes that neither fix a bug nor add a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(calculate): export isLeapYear and calculateSafePercentage

2 participants