Fix API: Validate and Clamp Grace Parameter in calculateStreak Function#8356
Open
tamilr0727-ux wants to merge 1 commit into
Open
Fix API: Validate and Clamp Grace Parameter in calculateStreak Function#8356tamilr0727-ux wants to merge 1 commit into
tamilr0727-ux wants to merge 1 commit into
Conversation
Contributor
|
@tamilr0727-ux is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR addresses the validation of the |
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes validation for the
graceparameter incalculateStreak()by enforcing the documented range of 0–7 before the value is used in streak calculations.Changes
Problem Addressed
Previously,
calculateStreak()accepted arbitrary grace values without validation, resulting in behavior that differed from the documentation. Invalid values such as excessively large numbers, negative values, or non-numeric inputs could produce inconsistent results.This update guarantees that the function always operates with a valid grace value within the supported range.
Validation
Implemented tests covering:
Verification
Fixes #6739
Pillar
Visual Preview
Can Check in the Files Changed Section.
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.