This repository was archived by the owner on Oct 22, 2019. It is now read-only.
Allow passing already configured redis client to the storage adapter#27
Open
bdudelsack wants to merge 1 commit intoJimdo:masterfrom
Open
Allow passing already configured redis client to the storage adapter#27bdudelsack wants to merge 1 commit intoJimdo:masterfrom
bdudelsack wants to merge 1 commit intoJimdo:masterfrom
Conversation
bdudelsack
force-pushed
the
reuse-redis-client
branch
from
54d48a4 to
76b3ec0
Compare
bdudelsack
force-pushed
the
reuse-redis-client
branch
from
76b3ec0 to
71ecf64
Compare
Contributor
|
What's the benefit of reuse here? |
Author
|
In my application i already have configured Redis instance, so i don't need to make another one at the point of prometheus client creation. Actually i think that redis configuration should be taken out of the library and the end user should instantiate it by himself because it out of scope of the lib. |
|
This project is dead, but I'm maintaining it under my employer - https://github.com/endclothing/prometheus_client_php. Feel free to submit the PR there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.