Validate integer-valued floating-point inputs consistently - #97
Merged
Merged
Conversation
Apply the existing zero-fraction check to AbstractFloat and cover public scalar, nullable, property, and array validation. AI disclosure: This work was prepared with assistance from OpenAI Codex.
Member
Author
|
Merged as AI disclosure: This work was prepared with assistance from OpenAI Codex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validating
Float32(3)againsttype="integer"returned a type error, althoughFloat64(3)passed. The same mismatch affected Float16 and BigFloat, including values inside arrays and object properties.Apply the existing
isintegercheck toAbstractFloat. This follows draft-07 section 6.1.1, which defines integer instances by their fractional part. It avoids converting large values to a machine integer. Fractions, NaN, infinities, and Boolean instances remain rejected by integer schemas.Validation:
git diff --check, and an independent private review pass. All seven hosted checks pass at03750bbf34430956460496a8664b93e69e5f87bb. All six native coverage uploads were accepted for the correct repository/head and finished processing; aggregate coverage is 96.46%. The ordinary squash merge isbcaa1be86dee593e917daf200d1208d3d2d49eb7, whose tree equals the locally tested head. Both main workflows and all seven jobs pass; all six main uploads were also accepted and processed at 96.46%.Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.