Repository navigation
Apply string validation to AbstractString inputs - #98
Merged
Merged
Conversation
Use the existing string rules for slices and lazy strings, including type, length, pattern and nested error locations. AI disclosure: This work was prepared with assistance from OpenAI Codex.
Member
Author
|
Merged as The 68 public controls and both full 5,867-assertion suites pass on Julia 1.9.4 and 1.13.1. This fixes type checking and length/pattern enforcement together for AbstractString values, including SubString and LazyString. AI disclosure: This work was prepared with assistance from OpenAI Codex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubStringandLazyStringvalues were rejected bytype="string", while length and pattern assertions without a type restriction silently accepted them. The schema generator already declares these types as strings.Use
AbstractStringfor the instance checks intype,maxLength,minLength, andpattern. This applies the existing string rules together and preserves the current Unicode codepoint length and regular-expression behavior.Validation:
git diff --check, and an independent private review pass. All seven hosted checks pass at30fdff54f45432494b7da5907d234da33ea2706a. All six native coverage uploads were accepted for the correct repository/head and finished processing; aggregate coverage is 96.46%. The ordinary squash merge isdf66dffa04f3f299c6e69fcc41c18639a3659238, with the same tested tree. All seven main-branch checks pass; all six main coverage uploads were accepted and processed at 96.46%.Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.