Repository navigation
Validate abstract vector array instances - #99
Merged
Merged
Conversation
AI disclosure: This work was prepared with assistance from OpenAI Codex.
Member
Author
|
Merged the array-instance and offset-indexing fixes. Concrete arrays retain their existing behavior; one-dimensional views, ranges, and bit vectors now receive array validation, and tuple tail checks use logical JSON positions for offset-indexed vectors. All 73 regression assertions and both full 5,940-assertion suites pass on Julia 1.9.4 and 1.13.1. The exact published head and identical merge tree each passed all seven hosted checks and all six accepted, processed coverage uploads (96.46%). AI disclosure: This work was prepared with assistance from OpenAI Codex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Views, ranges, and bit vectors are rejected by
type="array"even though the schema generator and array keywords already support abstract vectors. AcceptAbstractVectorinstances while retaining existing concrete-array behavior.The shared additional-items loop now iterates tail values and reports their logical JSON positions. This also fixes the existing bounds errors for offset vectors with tuple
itemsand schema-valuedadditionalItems. No new exports or dependencies.Validation:
git diff --check, and a complete independent private review pass. Hosted CI and coverage processing are pending.Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.
Validation after publication: all seven exact-head checks passed, and all six correct-repository coverage uploads were accepted and processed (96.46%). The ordinary merge has the same tested Git tree; master also passed all seven checks and all six accepted and processed coverage reports (96.46%).