fix(kiloclaw): block retrial after destroyed instance#2580
Open
jeanduplessis wants to merge 1 commit intojdp/kiloclaw-spec-compliance-pr1-specsfrom
Open
fix(kiloclaw): block retrial after destroyed instance#2580jeanduplessis wants to merge 1 commit intojdp/kiloclaw-spec-compliance-pr1-specsfrom
jeanduplessis wants to merge 1 commit intojdp/kiloclaw-spec-compliance-pr1-specsfrom
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-2026-03-05 · 385,127 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Counts destroyed personal KiloClaw instances as prior trial history when reporting billing status.
Why this change is needed
Users who destroyed a personal instance could still see
trialEligible=truebecause billing status only looked at non-destroyed personal instances. That drifted from intended first-trial-only rule and fromensureProvisionAccess, which already blocks new trials once any prior personal history or subscription exists.How this is addressed
trialEligible=false.Verification
pnpm test -- apps/web/src/routers/kiloclaw-billing-router.test.tspnpm typecheckpnpm formatVisual Changes
N/A
Reviewer Notes
Human Reviewer
getBillingStatusaligned with provision-time gating.Code Reviewer Agent
Code Reviewer Notes
getPersonalBillingStatuspreviously queriedkiloclaw_instanceswithdestroyed_at IS NULLwhen derivingtrialEligible. This PR removes that filter for personal rows only; organization rows remain excluded.