Repository navigation
Select shared mesh tessellation modes per request - #1491
Joe-Spencer wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1491 +/- ##
=======================================
Coverage ? 41.95%
=======================================
Files ? 35
Lines ? 1938
Branches ? 0
=======================================
Hits ? 813
Misses ? 1125
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Irev-Dev
left a comment
There was a problem hiding this comment.
I know it's still in draft, but this all seems good.
| pub struct TessellationOptions { | ||
| /// Use accurate tessellation (default). Set to false for standard display tessellation. | ||
| #[builder(default = true)] | ||
| pub accurate: bool, |
There was a problem hiding this comment.
I really don't like the name accurate nor that fact that it's a boolean. Could we make this more explicit? I suggest something like:
enum Mode {
Visual,
Accurate,
}
There was a problem hiding this comment.
Yeah we could do that. In HOOPs the field is A3DBool m_bAccurateTessellation so I was building on that but we may not always use HOOPs here. Enum is a better choice since we could offer more specific options in the future.
Add optional shared
tessellation.modesettings to glTF/GLB, FBX, OBJ, PLY, and STL exports. The enum acceptsvisualandaccurate; omitted options preserve the existing wire shape, and an empty tessellation object defaults to Accurate. STEP and Rhino exports do not expose mesh tessellation settings.The ZDS viewport can request Visual mode on one
exportcommand while ordinary exports on the same connection retain their default. This carries the mode selection from #1462 onto the current schema without adding its detail presets. The public API names stay unchanged.Refreshed against current main, preserving the Rhino and compression additions. Includes generated OpenAPI and binding support, with serialization/default regressions for all five mesh formats and the non-mesh formats. All 40 library and integration tests pass locally with all features; PR CI is green.