Skip to content

Select shared mesh tessellation modes per request - #1491

Draft
Joe-Spencer wants to merge 5 commits into
mainfrom
codex/viewport-standard-tessellation
Draft

Joe-Spencer wants to merge 5 commits into
mainfrom
codex/viewport-standard-tessellation

Conversation

@Joe-Spencer

@Joe-Spencer Joe-Spencer commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Add optional shared tessellation.mode settings to glTF/GLB, FBX, OBJ, PLY, and STL exports. The enum accepts visual and accurate; omitted options preserve the existing wire shape, and an empty tessellation object defaults to Accurate. STEP and Rhino exports do not expose mesh tessellation settings.

The ZDS viewport can request Visual mode on one export command while ordinary exports on the same connection retain their default. This carries the mode selection from #1462 onto the current schema without adding its detail presets. The public API names stay unchanged.

Refreshed against current main, preserving the Rhino and compression additions. Includes generated OpenAPI and binding support, with serialization/default regressions for all five mesh formats and the non-mesh formats. All 40 library and integration tests pass locally with all features; PR CI is green.

@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 8 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@f1f6c5f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/format/mod.rs 69.23% 4 Missing ⚠️
modeling-cmds/src/format/tessellation.rs 88.23% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1491   +/-   ##
=======================================
  Coverage        ?   41.95%           
=======================================
  Files           ?       35           
  Lines           ?     1938           
  Branches        ?        0           
=======================================
  Hits            ?      813           
  Misses          ?     1125           
  Partials        ?        0           
Flag Coverage Δ
unittests 41.95% <87.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Irev-Dev Irev-Dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's still in draft, but this all seems good.

Comment thread modeling-cmds/src/format/gltf.rs Outdated
pub struct TessellationOptions {
/// Use accurate tessellation (default). Set to false for standard display tessellation.
#[builder(default = true)]
pub accurate: bool,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like the name accurate nor that fact that it's a boolean. Could we make this more explicit? I suggest something like:

enum Mode {
    Visual,
    Accurate,
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we could do that. In HOOPs the field is A3DBool m_bAccurateTessellation so I was building on that but we may not always use HOOPs here. Enum is a better choice since we could offer more specific options in the future.

@Joe-Spencer Joe-Spencer changed the title Select standard tessellation on individual GLTF requests Select shared mesh tessellation modes per request Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants