Move UpdatesSiteInformation trait to SiteService#3856
Merged
Conversation
In the time since the `UpdatesSiteInformation` trait was created, CDash has developed a service layer which is a more appropriate location for these kinds of utility methods. This PR moves the contents of the `UpdatesSiteInformation` trait to a static method in a new `SiteService`.
williamjallen
force-pushed
the
site-service
branch
from
July 20, 2026 19:45
11d616f to
c25874b
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the time since the
UpdatesSiteInformationtrait was created, CDash has developed a service layer which is a more appropriate location for these kinds of utility methods. This PR moves the contents of theUpdatesSiteInformationtrait to a static method in a newSiteService.