fix: use showSaveFilePicker for state export with browser fallback#83
Merged
jourdain merged 1 commit intoKitware:masterfrom May 1, 2026
Merged
Conversation
jourdain
reviewed
May 1, 2026
| utils.download(fname, content, 'application/json'); | ||
| }); | ||
| } | ||
| """, |
Collaborator
There was a problem hiding this comment.
While valid I would rather capture that JS code inside here and make the click just click="utils.quickview.exportDownload(download_name)"
Collaborator
There was a problem hiding this comment.
In JS, you have access to trame but to change state variable, you will need to do window.trame.state.set("show_export_dialog", false).
Collaborator
There was a problem hiding this comment.
And the utils are available under window.trame.utils.
Collaborator
|
I'll do a small cleanup in another push |
Collaborator
|
Done it here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve state file export to use the native save-as dialog when available in the browser.
Note: This fix does not allow for the user to enter a path instead of just a filename. browser technology has file system access restrictions. We still ask for just a filename here. So, there are are three cases:
What we changed:
Fallback chain:
Remote host access:
The showSaveFilePicker API requires a secure context. When accessing QuickView remotely over plain http://, the native save dialog will not be available and the fallback browser download is used instead. To enable the full save-as experience for remote users:
closes #78