fix(i/o): chain loadData promise in instead of branching prevents unhandled rejection#3438
Merged
finetjul merged 1 commit intoKitware:masterfrom Mar 12, 2026
Merged
Conversation
Member
|
Please clean up your commit message, there is a "fix: " too many. |
…events unhandled rejection Kitware#3437
aerogt3
force-pushed
the
fix-3437-STLReader-promise-chain
branch
from
47ff178 to
46cfffd
Compare
|
🎉 This PR is included in version 35.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
See #3437
Results
Passes tests, local usage shows resolution in STLReader
Changes
See #3437
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting