Repository navigation
Promote methods to AbstractNotification - #324
Merged
bbimber merged 1 commit intoOct 30, 2026
Merged
Conversation
labkey-martyp
approved these changes
Oct 30, 2026
| long count = ts.getRowCount(); | ||
| if (count > 0) | ||
| { | ||
| msg.append("<b>WARNING: There are ").append(count).append(" ").append(message).append("</b><br>\n"); |
There was a problem hiding this comment.
Escape message? PageFlowUtil.filter(message)
Collaborator
Author
There was a problem hiding this comment.
That's a valid point, although I think the thing to do is refactor all of NotificationService to use HtmlString. That touches a lot of code. There are no user-supplied values, so the notifications should be pretty safe, but I will make a note to look into this at some point.
bbimber
added a commit
to LabKey/BimberLabKeyModules
that referenced
this pull request
Oct 30, 2026
This backports a simple refactor from discvr26.7 to release26.7, so it can be used by ONPRC EHR modules: LabKey/onprcEHRModules#1968 Related to: LabKey/LabDevKitModules#324
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports a simple refactor from discvr26.7 to release26.7, so it can be used by ONPRC EHR modules: LabKey/onprcEHRModules#1968.
Related to: LabKey/BimberLabKeyModules#309