Repository navigation
Deprecate SQLFragment.append(CharSequence cs), convert Study module - #288
Merged
Merged
Conversation
…ence) from the study module.
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
labkey-matthewb
changed the title
labkey-matthewb
marked this pull request as ready for review
October 20, 2026 22:38
labkey-adam
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
To further fortify SQL generation internally, we want to deprecate the use of append(CharSequence) and make any remaining "unsafe" usages easier to review e.g. remaining usages of setSqlUnsafe().
Related Pull Requests
Changes