EditableDetailPanel: compare form values against model with update columns#1959
Open
labkey-nicka wants to merge 7 commits intodevelopfrom
Open
EditableDetailPanel: compare form values against model with update columns#1959labkey-nicka wants to merge 7 commits intodevelopfrom
labkey-nicka wants to merge 7 commits intodevelopfrom
Conversation
cnathe
approved these changes
Mar 23, 2026
Contributor
cnathe
left a comment
cnathe
left a comment
There was a problem hiding this comment.
Code changes and refactor look good. Minor feedback.
| test('does not mutate original arrays', () => { | ||
| const arrA = ['b', 'a']; | ||
| const arrB = ['a', 'b']; | ||
| arrayEquals(arrA, arrB, true); |
Contributor
There was a problem hiding this comment.
any reason to check the other iterations / combinations of the 3rd and 4th params here? I assume not, just checking.
| }); | ||
|
|
||
| test('handles duplicate elements correctly with ignoreOrder', () => { | ||
| expect(arrayEquals(['a', 'a', 'b'], ['a', 'b', 'b'], true)).toBeFalsy(); |
Contributor
There was a problem hiding this comment.
is it worth a quick check as well that flipping the ignoreOrder boolean gives the expected behavior as well?
| const queryConfigs = useMemo(() => ({ model: queryConfig }), [queryConfig]); | ||
| const { keyValue, schemaQuery } = queryConfig; | ||
| const { schemaName, queryName } = schemaQuery; | ||
| const key = `${schemaName}.${queryName}.${keyValue}`; |
Contributor
There was a problem hiding this comment.
I thought we had some helper on QueryConfig or QueryModel for getting this type of key value, but I'm not seeing it.
labkey-nicka
force-pushed
the
fb_mv_edit_960
branch
from
5f851b3 to
1cb54d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses #960 by refactoring
EditableDetailPanelto compare form values against a query model row that contains all update columns.Related Pull Requests
Changes
EditingFormout ofEditableDetailPaneland load model with update columns. This model is subsequently used for value comparison.extractChanges()to account forcolumn.jsonType === 'array'arrayEqualsto fix edge cases of array mutation and delimiter collisions