-
Notifications
You must be signed in to change notification settings - Fork 2
GitHub Issue 954: Add error for duplicate values for parent inputs #1977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
514cabd
GitHub Issue 954: Add error for duplicate values for parent inputs
XingY 9f201d4
GitHub Issue 954: Add error for duplicate values for parent inputs
XingY b4dfe83
jest and api tests
XingY a7c9d7c
merge from develop
XingY b7a8a85
merge from develop
XingY 23ae43a
publish
XingY d20cee6
publish
XingY File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1123,6 +1123,7 @@ export function parsePastedLookup( | |
| let message: CellMessage; | ||
| let values: ValueDescriptor[]; | ||
| const unmatched: string[] = []; | ||
| const dupValues = new Set<string>(); | ||
|
|
||
| // Parse pasted strings to split properly around quoted values. | ||
| // Remove the quotes for storing the actual values in the grid. | ||
|
|
@@ -1134,10 +1135,15 @@ export function parsePastedLookup( | |
| unmatched.push(vt); | ||
| values = [{ display: vt, raw: vt }]; | ||
| } else { | ||
| const foundValues = new Set<string>(); | ||
| values = parsedValues.flatMap(v => { | ||
| const vt = v.trim(); | ||
| if (!vt) return []; | ||
|
|
||
| if (foundValues.has(vt)) { | ||
| dupValues.add(vt); | ||
| } | ||
| foundValues.add(vt); | ||
| const vl = vt.toLowerCase(); | ||
| const vd = descriptors.find(d => d.display && d.display.toString().toLowerCase() === vl); | ||
| if (vd) return [vd]; | ||
|
|
@@ -1153,6 +1159,12 @@ export function parsePastedLookup( | |
| .map(u => '"' + u + '"') | ||
| .join(', '); | ||
| message = { message: lookupValidationErrorMessage(valueStr, true) }; | ||
| } else if (dupValues.size > 0) { | ||
| const valueStr = Array.from(dupValues) | ||
| .slice(0, 4) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume the slicing is to keep the message size small and see that it's done in the previous block too, but it seems somewhat magical. |
||
| .map(u => '"' + u + '"') | ||
| .join(', '); | ||
| message = { message: `Duplicate values not allowed: ${valueStr}.` }; | ||
| } | ||
|
|
||
| return { message, valueDescriptors: List(values) }; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than one test with comments on the test cases, this could be better done as separate tests with the comments acting as the test name.