Delete all attachments when deleting multi-folder lists#7512
Merged
labkey-adam merged 1 commit intorelease26.3-SNAPSHOTfrom Mar 24, 2026
Merged
Delete all attachments when deleting multi-folder lists#7512labkey-adam merged 1 commit intorelease26.3-SNAPSHOTfrom
labkey-adam merged 1 commit intorelease26.3-SNAPSHOTfrom
Conversation
XingY
approved these changes
Mar 23, 2026
labkey-nicka
approved these changes
Mar 24, 2026
| @Override | ||
| public boolean accept(ListRow row) | ||
| { | ||
| return null != row.entityId(); |
Contributor
There was a problem hiding this comment.
nit: This could be done as a SQL filter instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We were orphaning attachments in multi-folder lists: https://github.com/LabKey/internal-issues/issues/984
Changes