Open
Conversation
also temporarily modfify TestDataGenerator
| return ret; | ||
| } | ||
|
|
||
| static final String FORM_DATE_ENCODED_PARAM = "formDataEncoded"; |
Contributor
There was a problem hiding this comment.
Seems like we need more client-side updates as formDataEncoded is no longer necessary. This encoding is being performed for all forms.
Contributor
Author
There was a problem hiding this comment.
I was hoping encodeFormDataQuote() would cover the client-side code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Whereas browsers seem to have trouble property formatting multipart/form-data POSTs, we will encode form names that include these three characters:
% " \For backward compatibility we will identify encoded field names by prepending
%_.quf_name->quf_namequf_why"?->%_quf_why%22%3FRelated Pull Requests
Changes