Workflow: Add Update Sample Status Action#7667
Open
labkey-alan wants to merge 5 commits into
Open
Conversation
labkey-alan
force-pushed
the
fb_workflow_sample_status
branch
from
5148f0c to
6ede52e
Compare
2 tasks
labkey-alan
force-pushed
the
fb_workflow_sample_status
branch
from
6775ce6 to
e4531cc
Compare
labkey-alan
force-pushed
the
fb_workflow_sample_status
branch
from
2a93f16 to
2856ddc
Compare
labkey-susanh
approved these changes
May 21, 2026
| * UPDATE_STATUS_KEY is true | ||
| * - STATUS_KEY is optional, but when present the value must be a valid status | ||
| * - REMOVE_FROM_STORAGE_KEY may only be present when STATUS_KEY is also present | ||
| * - If REMOVE_STORAGE_KEY is true, then the value for STATUS_KEY must represent a consumed state |
Contributor
There was a problem hiding this comment.
Suggested change
| * - If REMOVE_STORAGE_KEY is true, then the value for STATUS_KEY must represent a consumed state | |
| * - If REMOVE_FROM_STORAGE_KEY is true, then the value for STATUS_KEY must represent a consumed state |
| DataState state = SampleStatusService.get().getStateForRowId(container, statusId); | ||
|
|
||
| if (state == null) | ||
| return prefix + "Invalid " + STATUS_KEY + " (" + statusId + ")."; |
Contributor
There was a problem hiding this comment.
Perhaps:
Suggested change
| return prefix + "Invalid " + STATUS_KEY + " (" + statusId + ")."; | |
| return prefix + "invalid " + STATUS_KEY + " (" + statusId + ") for container " + container.getPath() + "." |
Add validation for sample status changes during Aliquot/Derive/Pool actions
… removeFromStorage
…t and easier to reason about
…ys, add comment clarifying validation logic
labkey-alan
force-pushed
the
fb_workflow_sample_status
branch
from
2856ddc to
5114c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation for sample status changes during Aliquot/Derive/Pool actions
Rationale
Related Pull Requests
Changes
Tasks 📍