Skip to content

require browser developer permission in order to create and modify survey designs - #8025

Merged
labkey-klum merged 4 commits into
developfrom
fb_issue_1526
Sep 9, 2026
Merged

require browser developer permission in order to create and modify survey designs#8025
labkey-klum merged 4 commits into
developfrom
fb_issue_1526

Conversation

@labkey-klum

Copy link
Copy Markdown
Contributor

Rationale

https://github.com/LabKey/internal-issues/issues/1526

Surveys have the ability to inject and execute javascript code onto the page previously insert permissions were required. This change raises that requirement to be similar to reports and other script authoring actions.

@labkey-klum
labkey-klum requested a review from cnathe September 7, 2026 21:14
@labkey-klum labkey-klum self-assigned this Sep 7, 2026

@cnathe cnathe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any doc updates or handoff for this change?

@labkey-klum labkey-klum changed the title require trusted analyst role in order to create and modify survey designs require browser developer permission in order to create and modify survey designs Sep 8, 2026
@labkey-klum

Copy link
Copy Markdown
Contributor Author

Do we need any doc updates or handoff for this change?

Yes, I'll need to change the implementation to check for BrowserDeveloperPermission instead. This will simplify things since I won't need to check for a site role.

@labkey-klum
labkey-klum merged commit a5729af into develop Sep 9, 2026
7 checks passed
@labkey-klum
labkey-klum deleted the fb_issue_1526 branch September 9, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants