Repository navigation
Annotate link timeouts as @NotNull - #8245
Merged
Merged
Conversation
labkey-jeckels
approved these changes
Oct 28, 2026
XingY
pushed a commit
that referenced
this pull request
Oct 29, 2026
## Rationale Update a few methods to take `@NotNull` link timeouts. The only caller who passed `null` has been migrated. Also, test a couple invariants in `HasPermissionOption.ALL.accept()`. ## Related Pull Requests - LabKey/MacCossLabModules#682
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Update a few methods to take
@NotNulllink timeouts. The only caller who passednullhas been migrated.Also, test a couple invariants in
HasPermissionOption.ALL.accept().Related Pull Requests