Skip to content

Add SAML reauth props to distributed application.properties file - #1543

Merged
labkey-adam merged 2 commits into
developfrom
fb_same_site_props
Oct 29, 2026
Merged

labkey-adam merged 2 commits into
developfrom
fb_same_site_props

Conversation

@labkey-adam

@labkey-adam labkey-adam commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Rationale

These properties are more likely to be used if they're in the application.properties file that gets distributed to customers and deployed. GH Issue 1748

Related Pull Requests

Changes

  • Add properties that should be enabled to allow Chromium browsers to reauthenticate via SAML
  • Eliminate unused NLP XML files

User Education

  • At a minimum, we should add a troubleshooting section for "Reauthentication failed: wrong user reauthenticated" when attempting to sign a notebook after authenticating with SAML. If they run into this problem, they should enable (or add) the two properties in application.properties. See the original issue: https://github.com/LabKey/internal-issues/issues/1436
  • Could add a bullet to the release notes update or configure section

@labkey-bpatel labkey-bpatel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor consistency nit: this adds server.servlet.session.cookie.http-only=true as an active line in the distributed application.properties, but in server/configs/application.properties it is still commented out - could we uncomment it here too so the two files match?

…tive comments vs. # for commented out properties (consistency).
@labkey-adam

Copy link
Copy Markdown
Contributor Author

Minor consistency nit: this adds server.servlet.session.cookie.http-only=true as an active line in the distributed application.properties, but in server/configs/application.properties it is still commented out - could we uncomment it here too so the two files match?

Sure. I uncommented it in the dev/test file. I also switched that file to consistently use ## for descriptions/instructions.

@labkey-adam
labkey-adam merged commit 45599b1 into develop Oct 29, 2026
6 checks passed
@labkey-adam
labkey-adam deleted the fb_same_site_props branch October 29, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants