Repository navigation
Add SAML reauth props to distributed application.properties file - #1543
Merged
Merged
Conversation
labkey-adam
requested review from
labkey-bpatel,
labkey-jeckels and
labkey-jony
October 28, 2026 23:58
labkey-bpatel
approved these changes
Oct 29, 2026
labkey-bpatel
left a comment
Contributor
There was a problem hiding this comment.
Minor consistency nit: this adds server.servlet.session.cookie.http-only=true as an active line in the distributed application.properties, but in server/configs/application.properties it is still commented out - could we uncomment it here too so the two files match?
…tive comments vs. # for commented out properties (consistency).
Contributor
Author
Sure. I uncommented it in the dev/test file. I also switched that file to consistently use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
These properties are more likely to be used if they're in the
application.propertiesfile that gets distributed to customers and deployed. GH Issue 1748Related Pull Requests
Changes
User Education