LKSM: Multivalue text choice automation: Assays#2918
Open
LKSM: Multivalue text choice automation: Assays#2918
Conversation
no formatting
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
DariaBod
changed the title
labkey-tchad
requested changes
Mar 23, 2026
| public static List<String> sortValues(List<String> values) | ||
| { | ||
| return values.stream() | ||
| .filter(s -> !s.isEmpty()) |
Member
There was a problem hiding this comment.
This should probably throw an exception if one of the values is empty. If an empty value ends up in here, something probably went wrong upstream.
Suggested change
| .filter(s -> !s.isEmpty()) | |
| .peek(s -> { if (s.isEmpty()) throw new IllegalArgumentException("Empty values aren't allowed: " + values);}) |
| elementCache().manageMenu.doMenuAction("Edit Assay Design"); | ||
| } | ||
|
|
||
| public AssayImportPage clickImportData() |
Member
There was a problem hiding this comment.
I think this method didn't exist before because many assay types have custom import pages that aren't compatible with the standard AssayImportPage. I think it's fine to have this method but it should be documented that it only works for Standard assays.
| while (textChoices.size() < size) | ||
| { | ||
| String generated = randomString(randomInt(1, 25)).trim(); | ||
| String generated = randomString(randomInt(1, 25), "%<>").trim(); |
Member
There was a problem hiding this comment.
Why can't text choices include these characters? Any special exclusions should be documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Added method for MVTC formatting and couple of other helper methods.
Related Pull Requests