Fix for AuthenticationProviderReorderTest.testReorderConfigurations - #3183
Merged
DariaBod merged 1 commit intoSep 3, 2026
Merged
Conversation
labkey-danield
approved these changes
Sep 2, 2026
DariaBod
added a commit
to LabKey/platform
that referenced
this pull request
Sep 3, 2026
…8015) ## Rationale `onDragEnd` compared `globalSettings` against the whole `dirtinessData` object instead of `dirtinessData.globalSettings`, and `isEquivalent` compares key counts first, so `dirty` was unconditionally true after any drag-end — the unsaved-changes banner and navigate-away warning appeared even when a row was dropped back in place. `AuthenticationProviderReorderTest` relied on that banner to confirm the drag had landed, so it could not tell a failed drop from a successful one. ## Related Pull Requests - LabKey/testAutomation#3183 ## Changes - `AuthenticationConfiguration.onDragEnd` compares against `dirtinessData.globalSettings`, matching how `globalAuthOnChange` already does it. - `AuthenticationProviderReorderTest` reorders through `keyboardDragAndDrop` and waits for the now-meaningful unsaved-changes banner before saving. <!-- list of standard tasks (remove this comment to enable) ## Tasks - [ ] Claude Code Review - [ ] Manual Testing - [ ] Test Automation - [ ] Verify Fix -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
A single-jump Selenium drag can lift and drop having registered no movement, so the reorder silently does nothing. Some of the changes in this PR are already in develop due to previous test fixes.
Related Pull Requests
Changes
WebDriverWrapper.keyboardDragAndDrop(WebElement, int)drives the library's keyboard sensor instead of the mouse: Space to lift, one Arrow per step, Space to drop.dragAndDrop(from, to).FieldSelectionDialog.repositionFielddelegates to the shared helper instead of its own copy.LoginConfigRow.getDragHandle()exposes a row's drag handle. On the authentication configuration pagedragHandlePropssit on the row wrapper rather than the visible.domain-row-handleicon, so the handle is an ancestor of the row's component element.