Skip to content

AnimalRequests: package updates#977

Open
labkey-nicka wants to merge 5 commits into
release26.3-SNAPSHOTfrom
26.3_fb_animal_requests_app_0626
Open

AnimalRequests: package updates#977
labkey-nicka wants to merge 5 commits into
release26.3-SNAPSHOTfrom
26.3_fb_animal_requests_app_0626

Conversation

@labkey-nicka

@labkey-nicka labkey-nicka commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Rationale

Client-side package updates for the AnimalRequests module.

Related Pull Requests

Changes

  • Package updates
  • Migrate app to use @labkey/build
  • app and dev views automatically generated by @labkey/build
  • Revise scripts in package.json to match present day configuration
  • Remove unused betterScripts

@aschmidt34 aschmidt34 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 questions before I approve:

  1. I noticed package.json change version 1.1.0 to 0.0.0. Shouldn't 0.0.0 only be used in a non-production environment? Is this okay?
  2. I noticed our 'reallyClean' command was removed; however, we still use that. Was that an accident?

@labkey-nicka

Copy link
Copy Markdown
Contributor Author
  1. I noticed package.json change version 1.1.0 to 0.0.0. Shouldn't 0.0.0 only be used in a non-production environment? Is this okay?

This isn't a package that is published with a version to a npm package repository. This is used solely for building client-side applications within this LabKey module. We can leave it as 1.1.0 but the version does not serve a purpose and has no meaning in the context of a LabKey module.

  1. I noticed our 'reallyClean' command was removed; however, we still use that. Was that an accident?

I removed it since there was not a correlated better-npm-run command for reallyClean so it seems to be at best a no-op. Perhaps this is a built-in mechanism of better-npm-run that I was not aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants