Skip to content

Add glyph.h (Debug Visualizer) - #174

Merged
gbeeley merged 4 commits into
masterfrom
glyph-debug-visualizer
Sep 24, 2026
Merged

gbeeley merged 4 commits into
masterfrom
glyph-debug-visualizer

Conversation

@Lightning11wins

@Lightning11wins Lightning11wins commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Adds centrallix-lib/include/glyph.h, a set of macros for printing a repeating characters, useful for visualizing how long-running algorithms are progressing.

Glyphs are compiled out unless ENABLE_GLYPHS is defined, which is left commented out.

Split out of #77 at review request.

@Lightning11wins Lightning11wins self-assigned this Sep 11, 2026
@Lightning11wins Lightning11wins added ai-review Request AI review for PRs. size: small Easy to review, probably ~200 lines or fewer. labels Sep 11, 2026
@Lightning11wins Lightning11wins changed the title Add glyph.h debug visualizer Add glyph.h (Debug Visualizer) Sep 11, 2026
@greptile-apps

greptile-apps Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds an opt-in debug visualization header for printing recurring glyphs during long-running algorithms.

  • Defines enabled and compiled-out forms of the glyph macros.
  • Adds the standard-library headers required by the enabled implementation.
  • Renames the initializer and printing macros to camel case.
  • Documents and asserts that the interval must be greater than zero.

Confidence Score: 5/5

The PR appears safe to merge, with no accepted new findings or outstanding blocking review threads.

The enabled header now includes its required declarations, and the macro rename has no repository callers to break. Lightning11wins dismissed the conditional-caller concern without further context; that resolved thread does not lower merge confidence.

Important Files Changed

Filename Overview
centrallix-lib/include/glyph.h Introduces the optional glyph visualizer and updates its dependencies, naming, and interval validation.

Reviews (2): Last reviewed commit: "Require interval to be one or more." | Re-trigger Greptile

Comment thread centrallix-lib/include/glyph.h
Comment thread centrallix-lib/include/glyph.h
Comment thread centrallix-lib/include/glyph.h

@gbeeley gbeeley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a future improvement might be to make interval time based instead of modulus based, and for glyph() to NOP if the interval has not yet elapsed.

@gbeeley
gbeeley merged commit 82e53c7 into master Sep 24, 2026
2 checks passed
@Lightning11wins
Lightning11wins deleted the glyph-debug-visualizer branch September 24, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request AI review for PRs. size: small Easy to review, probably ~200 lines or fewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants