Prayer partners sorting + README cleanup

[nathanielbscout]

I was looking at the README and I realised that I had some things marked as claimed that I had started but never fully finished.

On my local machine I saw that I have changes that should complete the prayer partner sorting*, that I have some updated comments on the managed object contexts (which may be used properly after all), and that no progress was made on the crash (I couldn't regularly reproduce it).

Let me know if you want me to create a small PR to clean that up. I can update the marked items in the README and commit the sorting changes and comments.

* I think it was working [in July or August], but test it a little bit and compare with the android app.

[Littlesnowman88]

Hi Nathaniel.
You are free to update the readme and commit its changes directly to master. We'll put a little time to try and reproduce the crash; thank you for letting us know about your similar story with reproducing it.
As for the pull request, I think it's a good idea to make one so I can see the changes and test them. There are a few caveats you should know about, though:
It would be best for us if you did a pull request from your changes to development. That's the branch we've been working under.
In lieu of still not having a lightsys apple developer team, we have been working under my apple account and provisioning profiles. To handle this well, my suggestion is to actually merge the development branch with your branch first, and then change the bundle identifier and team back to yours. I will accept a merge under your team and bundle ID, but will make a commit afterwards with my team and bundle ID so that we can continue working with your changes during this last day of code-a-thon 2019. We also have significant enough changes to the development branch that it would save me a headache in code reviewing for the pull request.
My other request: you don't have to document everything, but I would appreciate some documentation with functions and function points related to your pull request changes. You can look at my iOSEventApp -> SidebarItemViewControllers -> AboutPageViewController.swift to see what I envision (admittedly, that's my own documentation style, and I don't intend to be egotistic). I appreciate your documentation of classes, extensions, etc., but if we can both practice also documenting functions and some function points or sections of code, it will make future development easier. Four of us windows guys have had some fun trying to understand swift this week X)
Blessings, and I'll be watching email/github for updates.
-Littlesnowman88

[nathanielbscout]

The PR is ready. I don't think there are many changes, and they should be pretty straightforward (I did update documentation where applicable).

I thought LightSys might have gotten approved for a developer team last year...
You're not egotistic, and I usually just use the style Xcode gives me with the cmd-opt-/ shortcut.
Thanks for venturing out into new territory!

[gbeeley]

LightSys has a (free!) Apple Developer Program Account.  As long as we only distribute free apps (not paid apps), the account remains free. - Greg nathanielbscout wrote on 3/22/19 10:59 AM:

…

The PR is ready. I don't think there are many changes, and they should be pretty straightforward (I did update documentation where applicable). I thought LightSys might have gotten approved for a developer team last year... You're not egotistic, and I usually just use the style Xcode gives me with the cmd-opt-/ shortcut. Thanks for venturing out into new territory! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEwoCO9suVd1DTxzBpNfZ9oEzYj5I2Uuks5vZQv1gaJpZM4cDQUn>.