Repository navigation
hostmot2: harden Smart Serial and absolute encoder handling - #4662
Open
sleepybishop wants to merge 6 commits into
Open
sleepybishop wants to merge 6 commits into
sleepybishop wants to merge 6 commits into
Conversation
sleepybishop
marked this pull request as ready for review
October 10, 2026 03:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #4488 as requested. Adds Smart Serial/absolute-encoder parsing, allocation and cleanup checks, validates flash geometry, and fixes floating-point parameter comparisons, including unchanged NaNs. Setup-mode state-machine changes remain excluded.
Includes reproducible mock tests. Local build, regression, sanitizer and static-analysis checks pass; hardware testing remains pending. Keeping this draft for review.