Repository navigation
tests: drop sudo from the test suite and the package CI job - #4663
Open
grandixximo wants to merge 1 commit into
Open
grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
Tests that installed a component with `${SUDO} halcompile --install`
now use plain halcompile and an executable skip file, so they run on RIP
and skip against installed packages. Remove SUDO, the control file
handling and -u from runtests, and sudo from the package-arch job.
Contributor
|
Hmm, is it a good idea to skip all this tests with installed Debian packages?
Of course, it makes tests easier, I could drop 3a6b4a4 |
Contributor
Author
|
The call on wether it is safe to skip them it's a call @BsAtHome already made a while ago, all new tests are already following this pattern as per his blocker, since the new pattern also simplifies the parallel testing, I just went back to fix the old tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #4648: no sudo while running tests or building packages.
${SUDO} halcompile --installuse plainhalcompileand an executableskipfile ([ -z "$SYSTEM_BUILD" ]), like kins-frames and kins-jacobian already do: they run on RIP, where the install goes into the tree, and skip against installed packages.controlfiles (Restrictions: sudo) are gone; relative-header-user only compiles and keeps running on packages.SUDO, nocontrolhandling, no-u. tests/README and writing-tests.adoc document theskipfile instead.sudopackage, testrunner is not in the sudo group.The sudo left in ci.yml is runner provisioning (apt, core_pattern sysctl), not build or test.
@BsAtHome one open point: nothing in tree passes
-u, but an out-of-tree script that does now gets the usage text and exit 0 without running anything. Should I keep-uas an accepted no-op for a while, or is removing it fine?