Skip to content

cppcheck fixes for ubuntu-26.04 #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hdiethelm wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −5
Open

cppcheck fixes for ubuntu-26.04 #4664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/scripts/build-headers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/bin/sh

set -eu #Needed so CI fails when anything is wrong
set -x

#Any arguments are passed to configure

cd src
./autogen.sh
./configure "$@" --disable-check-runtime-deps --enable-werror
make headers
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,12 @@ jobs:
- name: Install dependencies
run: |
set -x
.github/scripts/use-main-ubuntu-mirror.sh
sudo apt-get -q update
.github/scripts/install-deps.sh
sudo apt-get --yes install cppcheck
- name: Build headers
run: |
set -x
.github/scripts/build-headers.sh --with-realtime=uspace
- name: Cppcheck
run: |
set -x
Expand Down
2 changes: 1 addition & 1 deletion src/hal/classicladder/classicladder_gtk.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,7 @@ void MainSectionWindowInitGtk()


//no more used since menu/toolbar added...
#ifdef AAAAAAAAAAAAAAAAAAAAAA
#if 0
hboxbottom = gtk_hbox_new (FALSE,0);
gtk_container_add (GTK_CONTAINER (vbox), hboxbottom);
gtk_widget_show(hboxbottom);
Expand Down
2 changes: 1 addition & 1 deletion src/hal/classicladder/drawing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ void DrawElement( cairo_t * cr,int x,int y,int Width,int Height,StrElement Eleme
char DisplayColorState = ( DrawingOption==DRAW_NORMAL && !EditDatas.ModeEdit && InfosGene->LadderState==STATE_RUN );

//Cairo....
#ifdef AAAAAAAAAAAAA
#if 0
GdkGC * DynaGcOff;
GdkGC * TheGc;
GdkColor DynaGdkColor;
Expand Down
2 changes: 1 addition & 1 deletion src/hal/classicladder/vars_names.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
//===OLD CODE NO MORE USED===
//with names directly in it...
//to be deleted, but some precise errors codes aren't present in the new function...
#ifdef AAAAAAAAA
#if 0

char * CreateVarName(int Type, int Offset)
{
Expand Down
Loading