Some Refactoring #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gronke
commented
Dec 18, 2017
gronke
commented
- minor optimizations
- be explicit with comparisons
Owner
|
Hi gronke, thanks for your PR! I am currently thinking about porting the project to ES6 or even TypeScript altogether, so I hope you understand that I will have to leave your PR unmerged until there is a decision on that, as it improves a lot of ES5 code. So give me some more time - I will definetly incorporate the PR one way or the other! Regards |
Author
|
@LionC sure thing! Let me know when it's time for a rebase. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.