Skip to content

feat(standings): always show certain column in swiss - #7879

Merged
Rathoz merged 5 commits into
mainfrom
always-show-stats-swiss
Jul 30, 2026
Merged

feat(standings): always show certain column in swiss#7879
Rathoz merged 5 commits into
mainfrom
always-show-stats-swiss

Conversation

@Rathoz

@Rathoz Rathoz commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

Overwhelming feedback that some columns for performance should be shown whether or not they are tiebreakers
In the end, a Swiss table should show:

  • Match score
  • The second Essential data column, different from wiki
  • All other tiebreakers

Opted to implement the first one dynamically, so incase there's a scenario where it differs, it's preped instead of hardcoded for match score.

How did you test this change?

dev

@Rathoz
Rathoz marked this pull request as ready for review July 29, 2026 14:37
@Rathoz
Rathoz requested a review from a team as a code owner July 29, 2026 14:37
Copilot AI review requested due to automatic review settings July 29, 2026 14:37
@Rathoz
Rathoz requested a review from a team as a code owner July 29, 2026 14:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay code wise on phone

wasn't the idea to hide the tiebreaker columns (except the ones to always show) by default too?

@Rathoz

Rathoz commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

wasn't the idea to hide the tiebreaker columns (except the ones to always show) by default too?

It isn't in this ticket, and I don't see a ticket for it. So I don't think so

@hjpalpha

Copy link
Copy Markdown
Collaborator

wasn't the idea to hide the tiebreaker columns (except the ones to always show) by default too?

It isn't in this ticket, and I don't see a ticket for it. So I don't think so

since i can't access the tickets i wouldn't know

was this part of the ticket?
IMG_5350
screenshot from:
https://docs.google.com/document/d/1E0EeH87Hp86SPllaS649TFyPfDj6_z5R_-KdE8uytDk/edit?usp=drivesdk

@Rathoz

Rathoz commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

PR Summary contains most of the Ticket info, other than specifications on 2nd column.

Swiss won't have manual tables. We decided they are better represented by manual group tables.

@Rathoz
Rathoz merged commit 4be06a6 into main Jul 30, 2026
8 checks passed
@Rathoz
Rathoz deleted the always-show-stats-swiss branch July 30, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants