Skip to content

Fix Fork Pull Request Preview Discovery - #1171

Merged
CryZe merged 1 commit into
LiveSplit:masterfrom
CryZe:pull-request-preview-discovery
Oct 12, 2026
Merged

CryZe merged 1 commit into
LiveSplit:masterfrom
CryZe:pull-request-preview-discovery

Conversation

@CryZe

@CryZe CryZe commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Draft PR #1170 completed CI successfully and uploaded its preview artifact, but GitHub's commit-association API returned no PRs for the fork commit. The publisher consequently skipped deployment even though the current open PR's head matched the completed run.

List current open pull request heads directly and select the one matching the CI repository and head SHA. Keep pagination, require exactly one candidate, and fetch the selected PR again before using its artifact. The existing checks for closed, stale, ambiguous, and unrelated builds remain intact, and artifact files never supply PR identity.

Add regression coverage for a draft fork PR with empty commit associations and for unrelated open heads. All 17 helper tests, ESLint, strict TypeScript checks, and formatting checks pass.

A read-only diagnostic against the original live CI run verified that the updated helper selects PR #1170, its exact current head SHA, and artifact 11772036485. The temporary diagnostic workflow has been removed from the final change. Once this is on the default branch, rerun #1170's publisher to finish verifying Cloudflare upload and the PR conversation link.

@CryZe CryZe added CI Affects the Continuous Integration. bug labels Oct 12, 2026 — with ChatGPT Codex Connector
@CryZe CryZe self-assigned this Oct 12, 2026
@CryZe
CryZe force-pushed the pull-request-preview-discovery branch from 6f5b3d7 to 7f605bc Compare October 12, 2026 20:48
GitHub can return no commit associations for an open fork pull request, even when its current head matches successful CI and the preview artifact is available. Discover candidates by listing current open pull request heads instead so fork and draft previews can be found without those associations.

Keep discovery based on GitHub API metadata, require exactly one matching repository and head SHA, and recheck the selected pull request before using its artifact. Preserve pagination and the existing rejection of stale, closed, ambiguous, or unrelated builds.
@CryZe
CryZe force-pushed the pull-request-preview-discovery branch from 7f605bc to f78eb12 Compare October 12, 2026 20:51
@CryZe CryZe changed the title Fix Pull Request Preview Discovery Fix Fork Pull Request Preview Discovery Oct 12, 2026
@CryZe
CryZe marked this pull request as ready for review October 12, 2026 20:52
@CryZe
CryZe merged commit fd79c3c into LiveSplit:master Oct 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug CI Affects the Continuous Integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant