chore(packaging/copr): Use standard cmake macros#5341
Open
LecrisUT wants to merge 1 commit into
Open
Conversation
ReenigneArcher
requested changes
Jun 26, 2026
ReenigneArcher
force-pushed
the
chore/spec-cleanup/cmake
branch
from
8764719 to
4710e19
Compare
ReenigneArcher
previously approved these changes
Jun 26, 2026
ReenigneArcher
changed the title
ReenigneArcher
changed the title
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5341 +/- ##
=========================================
Coverage ? 27.55%
=========================================
Files ? 113
Lines ? 25587
Branches ? 11237
=========================================
Hits ? 7050
Misses ? 15380
Partials ? 3157
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
Member
|
copr builds failed: |
Author
Probably some inconsistent cd paths or such. I will look into it |
LecrisUT
force-pushed
the
chore/spec-cleanup/cmake
branch
2 times, most recently
from
bf2d380 to
44be8f3
Compare
This will pick up the distro's best generator
ReenigneArcher
force-pushed
the
chore/spec-cleanup/cmake
branch
from
44be8f3 to
31781bc
Compare
|
Member
|
Now only opensuse is failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will pick up the distro's best generator, e.g. since Fedora 44 it uses Ninja.
For now I am starting with a small PR because I am not sure what flow you would prefer for these kind of cleanups. One PR at a time or grouped together with documented individual commits?
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage