Skip to content

[ComfyUI-Windows] Add gfx1150 ROCm nightly index URL for Strix/Gorgon Point Ryzen AI APUs#1571

Merged
mohnjiles merged 3 commits intoLykosAI:mainfrom
NeuralFault:gfx1150-comfy
Mar 10, 2026
Merged

[ComfyUI-Windows] Add gfx1150 ROCm nightly index URL for Strix/Gorgon Point Ryzen AI APUs#1571
mohnjiles merged 3 commits intoLykosAI:mainfrom
NeuralFault:gfx1150-comfy

Conversation

@NeuralFault
Copy link
Contributor

Adds support for GPU detection and Pytorch index-url support for TheRock nightlies for the Strix Point and Gorgon Point GPUs in the Ryzen AI 300/400 series APUs for ComfyUI installation in Windows.

GPU architecture support:

  • Added handling for the gfx1150 architecture, mapping it to the https://rocm.nightlies.amd.com/v2-staging/gfx1150 index URL to support Strix/Gorgon Point GPUs.
  • Added clarifying comments for both gfx1150 (Strix/Gorgon Point) and gfx1151 (Strix Halo) to improve maintainability and clarity.

The index used is V2-staging but was informed that the PyTorch functionality is stable and that there is no tester hardware for the TheRock CI for it to pass their PyTorch tests and be promoted to V2 index of the repo.

Thanks to a ROCm/TheRock contributor astrelsky for bringing it to my attention and informing on it's stability.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the ComfyUI installation process on Windows by extending its GPU detection and PyTorch index-url support to include newer AMD Ryzen AI APUs. It specifically enables compatibility with Strix Point and Gorgon Point GPUs, ensuring that users with these architectures can properly install and utilize ComfyUI with ROCm.

Highlights

  • ROCm Support for New AMD APUs: Added support for the gfx1150 architecture, specifically targeting Strix Point and Gorgon Point Ryzen AI APUs, by mapping it to a new ROCm nightly index URL.
  • Staging Index URL Usage: The gfx1150 architecture now utilizes the https://rocm.nightlies.amd.com/v2-staging/gfx1150 index URL, which is noted as stable despite its staging status.
  • Code Clarity and Maintainability: Clarifying comments were added for both gfx1150 (Strix/Gorgon Point) and gfx1151 (Strix Halo) entries to enhance code readability and future maintenance.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • StabilityMatrix.Core/Models/Packages/ComfyUI.cs
    • Added a new case for gfx1150 to the indexUrl switch statement, directing it to the v2-staging ROCm nightly index.
    • Updated the gfx1151 case with a clarifying comment indicating it supports 'Strix Halo'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds support for the gfx1150 architecture (Strix/Gorgon Point APUs) for ROCm on Windows by providing the appropriate nightly build URL. The added comments for both gfx1150 and gfx1151 improve code clarity. I have one suggestion to improve maintainability by using constants for the URLs.

Copy link
Contributor

@mohnjiles mohnjiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) thank you!

@mohnjiles mohnjiles merged commit 5d8a68d into LykosAI:main Mar 10, 2026
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2026
@NeuralFault NeuralFault deleted the gfx1150-comfy branch March 10, 2026 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants