[ComfyUI-Windows] Add gfx1150 ROCm nightly index URL for Strix/Gorgon Point Ryzen AI APUs#1571
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the ComfyUI installation process on Windows by extending its GPU detection and PyTorch index-url support to include newer AMD Ryzen AI APUs. It specifically enables compatibility with Strix Point and Gorgon Point GPUs, ensuring that users with these architectures can properly install and utilize ComfyUI with ROCm. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds support for the gfx1150 architecture (Strix/Gorgon Point APUs) for ROCm on Windows by providing the appropriate nightly build URL. The added comments for both gfx1150 and gfx1151 improve code clarity. I have one suggestion to improve maintainability by using constants for the URLs.
Adds support for GPU detection and Pytorch index-url support for TheRock nightlies for the Strix Point and Gorgon Point GPUs in the Ryzen AI 300/400 series APUs for ComfyUI installation in Windows.
GPU architecture support:
gfx1150architecture, mapping it to thehttps://rocm.nightlies.amd.com/v2-staging/gfx1150index URL to support Strix/Gorgon Point GPUs.gfx1150(Strix/Gorgon Point) andgfx1151(Strix Halo) to improve maintainability and clarity.The index used is V2-staging but was informed that the PyTorch functionality is stable and that there is no tester hardware for the TheRock CI for it to pass their PyTorch tests and be promoted to V2 index of the repo.
Thanks to a ROCm/TheRock contributor astrelsky for bringing it to my attention and informing on it's stability.