Add support for MDA minimize_vectors#188
Open
PardhavMaradani wants to merge 2 commits intoMDAnalysis:mainfrom
Open
Add support for MDA minimize_vectors#188PardhavMaradani wants to merge 2 commits intoMDAnalysis:mainfrom
PardhavMaradani wants to merge 2 commits intoMDAnalysis:mainfrom
Conversation
Author
|
Hi, I am unable to figure out the build error below. Could you please help me and let me know if there is something I am missing? I was able to build this locally on my ubuntu environment, which is how I was able to run the performance tests with a working version in the referenced MDA PR #5235. Thanks |
Author
Author
|
Here are the benchmark results comparing against mda version (serial): Show benchmark resultsMDAnalysis's own |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds support for MDAnalysis
minimize_vectorsas described in MDA Issue #5234. MDA PR #5235 adds the backend support for this function in MDAnalysis. Thanks