do not stop on missing special reactions#983
Merged
VincentVanlaer merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
The case this intends to support is testing various nuclear reaction networks with custom rates. If you have an expansive set of custom reaction rates, you no longer have to remove the rates that are not present in the network you are currently testing.
Member
|
This looks fine to me. It relieves a pain point for users as well. |
mathren
reviewed
May 4, 2026
Contributor
mathren
left a comment
mathren
left a comment
There was a problem hiding this comment.
Agreed, this is a good change and there is a warning printed anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The case this intends to support is testing various nuclear reaction networks with custom rates. If you have an expansive set of custom reaction rates, you no longer have to remove the rates that are not present in the network you are currently testing.