add optional flag to disable mlt_fallback in TDC adjust_mass#988
Merged
Conversation
Member
|
Is there a situation to prefer the old behaviour? |
Member
Author
|
I don't know, but for now I think an optional control we can test is a good solution. |
VincentVanlaer
approved these changes
May 13, 2026
VincentVanlaer
left a comment
VincentVanlaer
left a comment
Member
There was a problem hiding this comment.
Feel free to merge once the comment is updated!
Expanded comments to clarify the fallback mechanism for TDC and MLT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr introduces a dev control which affects TDC. It allows zones touched by adjust mass to use TDC inste. I think this can be more consistent the falling back to mlt, and this control is needed to evolve TDC pulsation models with mass loss as well.
In my testing, pulsation models with mass loss generate noisy features and convection in the surface layers touched by adjust_mass, because of the mlt fallback. Not falling back fixes this issue.