File-Per-Process IB markers

[danieljvickers]

For some reason, I never added file-per-process for IB markers, and it is a slowdown constaint for some of the IB cases we are running. Adding this here. I tested this on the 2D_mibm_shock_cylinder case on 2 ranks and verified the visual output was correct.

Even though this is marked as "draft", it is ready for merge.

[github-actions]

Claude Code Review

Head SHA: f0f2b3c

Files changed:

• 2
• src/post_process/m_data_input.f90
• src/simulation/m_data_output.fpp

Findings:

• src/post_process/m_data_input.f90:119-127: t_step_string is declared only inside the #ifdef MFC_MPI block (lines 114-120), but the new parallel_io .and. file_per_process branch that references it (call s_int_to_str(t_step, t_step_string) and the subsequent write/concatenation) sits outside any #ifdef MFC_MPI guard. In a non-MPI build this branch still has to compile (Fortran doesn't skip unreached branches), so t_step_string is an undeclared identifier there and the file fails to compile without MFC_MPI defined, breaking the CPU/non-MPI build path.

[danieljvickers]

@sbryngelson Do you still want us to keep PRs as draft when they are done? This and the restart changes would both be useful for me to get merged. So it would be helpful to have them bumped up in terms of priority for merge if possible

[sbryngelson]

noted. i'll prioritize it and move it out of draft soon enough

[Copilot]

🟡 Changes recommended

The post-process source fails to compile without MPI because t_step_string is conditionally declared but unconditionally referenced.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds file-per-process output and post-processing support for immersed-boundary marker data.

Changes:

• Writes rank-local IB marker files alongside timestep data.
• Reads rank-local marker files during post-processing.

File summaries

File	Description
src/simulation/m_data_output.fpp	Writes per-rank IB marker files.
src/post_process/m_data_input.f90	Reads per-rank IB marker files.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

❌ Patch coverage is 38.70968% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.76%. Comparing base (d2d8cac) to head (acade37).

Files with missing lines	Patch %	Lines
src/simulation/m_data_output.fpp	47.61%	11 Missing ⚠️
src/post_process/m_data_input.f90	20.00%	7 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1802      +/-   ##
==========================================
- Coverage   62.81%   62.76%   -0.05%     
==========================================
  Files          84       84              
  Lines       21975    21993      +18     
  Branches     3224     3224              
==========================================
+ Hits        13804    13805       +1     
- Misses       5949     5967      +18     
+ Partials     2222     2221       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Lines of Code

File	Lines	Diff
src/simulation/m_data_output.fpp	1341	+16
src/post_process/m_data_input.f90	420	+12

Directory	Lines	Diff
simulation	27935	+16
post_process	3388	+12
total	46144	+28