📖 [Docs]: Release notes carry complete consumer adoption evidence - #204
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated guidance contains internal inconsistencies (notably release-impact “published coordinates” requirements and mismatched heading levels vs the example) that could mislead authors following the template.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the MSX PR Format documentation to treat release-bound PR bodies as the authoritative, consumer-facing adoption record, and to require explicit adoption and release-impact evidence that publication preserves.
Changes:
- Adds “source of truth” guidance connecting PR bodies to Release Management’s publication/provenance responsibilities.
- Requires structured
## Adopting this releaseand## Release impactsections, plus a consumer change record/template baseline/maintainer evidence split under Technical details. - Expands the example PR body to demonstrate the new required sections and evidence tables.
File summaries
| File | Description |
|---|---|
| src/docs/Ways-of-Working/PR-Format.md | Clarifies PR bodies as authored release notes and adds explicit adoption, release-impact, and evidence-record requirements. |
Review details
Suppressed comments (2)
src/docs/Ways-of-Working/PR-Format.md:166
- The guidance section uses a
#### Template baselineheading, but the Example block below uses### Template baseline. Aligning these heading levels avoids ambiguity about the expected structure inside the Technical details block.
#### Template baseline
src/docs/Ways-of-Working/PR-Format.md:179
- The guidance section uses a
#### Maintainer evidenceheading, but the Example block below uses### Maintainer evidence. Using the same heading level in both places will make the template easier to follow.
#### Maintainer evidence
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟢 Approval recommended
The documentation updates are internally consistent, links/anchors resolve correctly, and the described authoring/publication contracts align across PR Format and Release Management spec/design.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🟡 Changes recommended
Two documentation issues in changed lines (path-filter snippet copy/paste hazard and minor wording/grammar inconsistencies) should be corrected to avoid propagating incorrect guidance.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 3
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
There is at least one internal inconsistency in the updated documentation contract wording that could mislead authors about required release-decision evidence.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
src/docs/Ways-of-Working/PR-Format.md:130
- The “Effective decision” row currently reads as if a configured policy could supply the release decision instead of an explicit owned
release:*label. That conflicts with the Release Management spec’s requirement that a bump label is mandatory (no default) and risks confusing authors about what must appear in the PR body.
- Files reviewed: 8/8 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
Addressed the configured-default inconsistency from Copilot's review summary in |
There was a problem hiding this comment.
🟢 Approved
The changes are documentation-only, internally consistent across the touched standards/specs, and introduce no verified broken links or formatting defects in the modified sections.
Review details
- Files reviewed: 17/17 changed files
- Comments generated: 0 new
- Review effort level: Lite
Release-bound pull requests classify changes for their declared user/integrator audience and describe the incremental actions that audience needs to adopt them. Release levels come from an explicit decision or an opt-in repository default; missing decisions must block merge in CI. Published notes preserve the complete authored record and its source/template evidence.
Changed: Change type follows the target audience
Each initiative describes its audience and supported jobs; each repository README states its audience or explicitly adopts that definition and records any specialization. Users and integrators can be the same people: PSModule module users integrate commands into their work, and Process-PSModule users integrate the delivery workflow into their module repositories.
Change type follows the highest impact on supported uses, not file location, edit size, or the reviewer's perspective. An incompatible output, runtime requirement, or caller interface remains breaking even when an interactive command still works or only a manifest or
.github/file changes.Changed: Repository defaults are explicit policy decisions
For PR-driven releases, an owned bump label overrides the optional
DefaultBumpin.github/release.config.yml. The setting acceptspatch,minor, ormajor. If neither supplies a level and no validrelease:skipis selected, the decision is missing: there is no implicit patch fallback. Prerelease mode can use an explicit or configured bump, but the mode alone is not a level. Invalid defaults and conflicting owned labels fail rather than selecting a convenient fallback.The declared default is not evidence of compatibility: authors still assess the audience impact and override the default when needed. Release-label names, SemVer arithmetic, and pre-1.0 mapping remain unchanged. The optional ad hoc dispatch keeps its existing explicit-bump requirement.
Changed: Missing decisions block merge, not only publication
The release contract requires a named PR decision-validation check, enforced by the target branch's ruleset or protection. Missing, invalid, or conflicting decisions fail it before merge. The check re-evaluates source, release-label, and settings changes; a failed, pending, or absent required result prevents manual and automatic merge. A valid skip passes with a no-release outcome instead of skipping validation. Publication validates its actual inputs again.
This PR documents that contract; it does not implement producer CI workflows or change repository rulesets.
Changed: Consumer adoption and publication evidence are complete
PR descriptions include Adopting this release and Release impact sections, an applicability-aware consumer change record, and a verified immutable template baseline where applicable. Public interfaces belong in user-facing prose, and breaking behavior remains explicit independently of version classification.
The release-management contract preserves the release-bound title and complete description. Actual coordinates and provenance remain separate from authored prose, and version-computation and consumer-change baselines remain distinct. Bundled, optional ad hoc, and source-specific prerelease records retain equivalent evidence. Metadata corrections preserve an audit without changing artifacts or historical behavior. Release filters reflect product contracts, not directory names alone.
Adopting this release
DefaultBumpin the release settings. An explicit level wins; neither source is an error, not a patch default. Selectrelease:skipfor a no-release decision. Verify the resolved level against the audience impact.Release impact
release:skip, documentation only.Technical details
Consumer change record
DefaultBump; neither source fails. Required CI validates the decision and blocks merge on missing/invalid/conflicting input.Template baseline
Not applicable: this PR changes shared standards, not a versioned framework integration or its template. The PR-format skill remains an unchanged thin pointer; no plugin metadata or version change is needed.
Maintainer evidence
6c07314/354dd8c, audience clarification inb1a8262/e55c80b, and decision/gate correction infd32b41.5124988102identified the default-policy contradiction in its suppressed summary. The earlier zero-inline-comment verdict missed that concern. Review now includes the complete summary, including suppressed comments; zero inline comments alone is not a clean round.DefaultBumpreuses the setting name from 📖 [Docs]: Release bumps now have a configurable default #196, but the user explicitly rejected that PR's implicit patch fallback. Coordination is recorded there. Its branch, release-type redesign, and label rename remain untouched and need reconciliation before merge.The walkthroughs below assess the documentation contract, not a running producer or the PSModule pilot:
Relevant issues (or links)
Related work