MDEV-38180: Added XXH3 and XXH32 (64 bit) sql functions #4500
+195
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gkodinov
added
the
External Contribution
Author
|
@FooBarrior @mariadb-YuchenPei please review🙂 |
gkodinov
reviewed
Jan 5, 2026
Contributor
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This is a preliminary review.
Please consider filling up a complete specification of the function into the related jira. E.g.: How does it calculate the hash for various data types, how does collation matter for strings, type and number of arguments, nullability, expected data type etc.
Please also find one additional optional arguments suggestion below.
| return 0; | ||
| } | ||
|
|
||
| uint32_t h= XXH32((const void*) res->ptr(), res->length(), 0); |
Contributor
There was a problem hiding this comment.
FWIW, PHP (https://php.watch/versions/8.1/xxHash) supports passing "secret" and "seed" to the XXHASH function. Should you consider the same?
These can be optional too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds native SQL functions
XXH32()andXXH3()exposing xxHash algorithms.Release Notes
Added XXH32() and XXH3() SQL functions that return 32‑bit and 64‑bit xxHash digests (unsigned integers). NULL or empty input returns SQL NULL.
How can this PR be tested?
./mysql-test/mtr main.func_xxh
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check