MDEV-40936 Install test binaries to libexecdir instead of bindir - #5608
Open
dhandzus wants to merge 1 commit into
Open
MDEV-40936 Install test binaries to libexecdir instead of bindir#5608dhandzus wants to merge 1 commit into
dhandzus wants to merge 1 commit into
Conversation
Test-component binaries (mariadb-test, mariadb-client-test,
mariadb-test-embedded, mariadb-client-test-embedded, test-connect-t)
are not intended for direct invocation by users and are not meant to
appear in $PATH, therefore install them to libexecdir instead of bindir.
Changes:
- Add INSTALL_LIBEXECDIR to all cmake install layouts
(STANDALONE, RPM, DEB, SVR4)
- Set DESTINATION ${INSTALL_LIBEXECDIR} for mariadb-test,
mariadb-client-test, mariadb-test-embedded,
mariadb-client-test-embedded, and test-connect-t
- Update mariadb-test-run.pl to find test binaries under
libexec/ for installed-layout runs
- Update debian/mariadb-test.install paths accordingly
|
|
gkodinov
added
the
External Contribution
gkodinov
approved these changes
Aug 28, 2026
gkodinov
left a comment
gkodinov
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution! This is a preliminary review (https://github.com/MariaDB/server/blob/main/COMMUNITY_CONTRIBUTIONS.md#preliminary-review).
LGTM. Please stand by for the final review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-component binaries (mariadb-test, mariadb-client-test, mariadb-test-embedded, mariadb-client-test-embedded, test-connect-t) are not intended for direct invocation by users and are not meant to appear in $PATH, therefore install them to libexecdir instead of bindir.
Changes:
The test suite was executed successfully in debug mode.