Reset missing position data if missing - #4670
Open
Withalion wants to merge 1 commit into
Open
Conversation
Coverage Report for CI Build 32851747166Warning No base build found for commit Coverage: 59.096%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
xkello
reviewed
Sep 3, 2026
| const bool hasHacc = localPosition.hasAttribute( QGeoPositionInfo::HorizontalAccuracy ); | ||
| if ( hasHacc && !qgsDoubleNear( localPosition.attribute( QGeoPositionInfo::HorizontalAccuracy ), mLastPosition.hacc ) ) | ||
| const double newHorizontalAccuracy = localPosition.hasAttribute( QGeoPositionInfo::HorizontalAccuracy ) ? | ||
| localPosition.attribute( QGeoPositionInfo::HorizontalAccuracy ) : std::numeric_limits<double>::quiet_NaN();; |
Contributor
There was a problem hiding this comment.
The double semicolon might be a typo. Same on line 217
xkello
reviewed
Sep 3, 2026
| if ( hasSpeedInfo && !qgsDoubleNear( localPosition.attribute( QGeoPositionInfo::GroundSpeed ), mLastPosition.speed ) ) | ||
| const double newSpeed = localPosition.hasAttribute( QGeoPositionInfo::GroundSpeed ) ? | ||
| localPosition.attribute( QGeoPositionInfo::GroundSpeed ) * 3.6 : std::numeric_limits<double>::quiet_NaN(); // convert from m/s to km/h | ||
| if ( !qgsDoubleNear( newSpeed, mLastPosition.speed ) ) |
Contributor
There was a problem hiding this comment.
If both of these will be NaN, thats always false no? I think qgsDoubleNear won't ever return true if it is comparing NaN values. So it goes through even when it shouldn't and forces positionDataHasChanged to true. The attributes stay missing though and this stays like that on every consecutive update right? Is that intended? Same applies to other if statements bellow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue where stale/untrue position data is shown to users if the data is missing from newer position update. We will clear the data now.